Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing http.status.response_code when there is a broken pipe error #4611

Closed
danpayne17 opened this issue Feb 7, 2024 · 2 comments · Fixed by #4770
Closed

Missing http.status.response_code when there is a broken pipe error #4611

danpayne17 opened this issue Feb 7, 2024 · 2 comments · Fixed by #4770
Assignees

Comments

@danpayne17
Copy link

Describe the bug
If the caller closes the connection before the router is done sending the response (e.g. broken pipe), the router span never gets tagged with http.status.response_code. Consequently, these are the only requests that do not show any status code in DataDog.

To Reproduce
Steps to reproduce the behavior:

  1. Insert code into a subgraph resolver so that it waits 10 seconds before responding to requests from router
  2. Send request to router using curl
  3. Cancel request (ctrl-c) while subgraph is waiting to respond which induces a broken pipe error
  4. Observe in DataDog that the trace for the above request has no status code

Expected behavior
Every trace should have a response status code so that DataDog queries can use the status code as a predicate

Router:

  • OS: Amazon Linux 2023
  • Version: 1.37.0
@BrynCooke
Copy link
Contributor

Just wondering if status code 499 would be appropriate here? It's non-standard, but widely used because of nginx.

@danpayne17
Copy link
Author

Yes, I think 499 status code would be a good fit and would certainly work for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants