Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemtry_sdk pulls in async-std #4262

Open
semtexzv opened this issue Nov 23, 2023 · 3 comments
Open

Opentelemtry_sdk pulls in async-std #4262

semtexzv opened this issue Nov 23, 2023 · 3 comments
Assignees
Labels

Comments

@semtexzv
Copy link

Describe the bug
Latest version of apollo-router includes opentelemetry crate with defaults enabled, and somehow this ends up including async_std into the dependency tree.

@bnjjj
Copy link
Contributor

bnjjj commented Nov 23, 2023

Hmm indeed, good catch. I think it's due to this line bca9d86#diff-aca654efc6c22bebf4bd167370ab3bf380f3e086befe3d7c6761a8f7eb59d89cR139

If we only require that feature in dev-deps I think it will be enough to get rid of async-std in the router deps. I'm not on my computer right now, feel free to open a PR and check it works as expected

@bnjjj bnjjj added the good first issue Good for newcomers label Nov 23, 2023
@bnjjj
Copy link
Contributor

bnjjj commented Nov 24, 2023

My bad, it's already part of our dev-deps

@nicholascioli
Copy link
Contributor

Looks like fixing this might require changes to upstream. The issue is that one of the dev-dependencies pulls in the testing feature from opentelemetry_sdk which pulls in all of the supported async runtimes.

A potential fix would be to just copy all of the features currently in the testing set and remove async-std, but since the feature set includes feature flags for dependencies of opentelemetry_sdk and cargo does not allow / in feature sets defined outside of the owning project, this isn't yet possible to do without upstream changes.

(As a note, it does seem like this might be possible in a later edition of rust)

@nicholascioli nicholascioli self-assigned this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants