Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Agent configuration - Update the documentation #4177

Closed
o0Ignition0o opened this issue Nov 9, 2023 · 2 comments
Closed

Telemetry: Agent configuration - Update the documentation #4177

o0Ignition0o opened this issue Nov 9, 2023 · 2 comments

Comments

@o0Ignition0o
Copy link
Contributor

Followup to #3950, the tracing configuration documentation is out of date:

trace_config doesn't exist anymore since #4044

image

This image claims jaeger: agent: endpoint takes a socket address, yet shows a hostname+port, which the router won't allow.

As a side effect of us using serde untagged enums, errors raised while trying to deserialize to a variant greet the user with a difficult to diagnose error message:

plugin apollo.telemetry could not be configured: data did not match any variant of untagged enum Config
@oliverjumpertz
Copy link
Contributor

oliverjumpertz commented Nov 9, 2023

This has actually already been solved by @BrynCooke with #3962 :)

Just checked when I wanted to quickly fix the docs.

@abernix
Copy link
Member

abernix commented Nov 27, 2023

Thanks for pointing that out, @oliverjumpertz! Closing as it's already been fixed! (Thanks, @BrynCooke , too. ;) )

@abernix abernix closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants