Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics and spans missing #4083

Open
Tracked by #3226
BrynCooke opened this issue Oct 23, 2023 · 0 comments
Open
Tracked by #3226

Metrics and spans missing #4083

BrynCooke opened this issue Oct 23, 2023 · 0 comments

Comments

@BrynCooke
Copy link
Contributor

BrynCooke commented Oct 23, 2023

Users are asking why their metrics and spans do not match the external telemetry they get from their load balancers.

We need to make telemetry the first layer that is called after Axum.
Currently we have a bunch of stuff in random layers that have been added before plugins get a look in. This means that their timing and errors are not captured in spans or metrics.

We've sort of hacked around this by putting some telemetry stuff earlier, but it a mess and can be cleaned up if we make the random layers be part of the regular request lifecycle and thus telemetry plugin can happen first.

@BrynCooke BrynCooke changed the title Make telemetry the first layer that is called. * Discuss with team Make telemetry the first layer that is called. Oct 23, 2023
@BrynCooke BrynCooke changed the title Make telemetry the first layer that is called. Make telemetry the first layer that is called Oct 23, 2023
@BrynCooke BrynCooke changed the title Make telemetry the first layer that is called Metrics and spans missing Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant