Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include specified correlation request header value(s) in all router log statements #3612

Closed
danpayne17 opened this issue Aug 18, 2023 · 3 comments

Comments

@danpayne17
Copy link

Is your feature request related to a problem? Please describe.
In the gateway it was simple to establish a log context that included per request data to both provide context around the log statement but also to allow correlation of multiple log statements across the gateway, subgraphs and upstream services that all participated in the request. Things in the log context are typically correlation IDs, request properties and user properties.
Describe the solution you'd like
We would like to be able to specify a set of request header names and when present, they header name and value would automatically be added to every router log message.

Describe alternatives you've considered
N/A

Additional context
N/A

@abernix
Copy link
Member

abernix commented Aug 21, 2023

This relates to #3226

@BrynCooke
Copy link
Contributor

It's now possible to expose headers as span attributes. This will appear in the next release.

@abernix
Copy link
Member

abernix commented Nov 29, 2023

For reference, we believe that will land in v1.35.0 which is currently in release candidate stage (https://github.com/apollographql/router/releases/tag/v1.35.0-rc.0, atm!), but that RC does have one though currently have one known telemetry bug that we discovered during our larger deployment test runs. We believe that will be fixed later today (and surface in rc.1 😄 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants