Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace_id is not always displayed in json logs #3208

Closed
bnjjj opened this issue Jun 2, 2023 · 1 comment · Fixed by #5447
Closed

trace_id is not always displayed in json logs #3208

bnjjj opened this issue Jun 2, 2023 · 1 comment · Fixed by #5447
Assignees
@bnjjj
Labels
bug component/logging component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it. story/logging

Comments

@bnjjj
Copy link
Contributor

bnjjj commented Jun 2, 2023

For now only logs in span router contains the trace_id. We need to fix this in the json formatter or somewhere else
@bnjjj bnjjj added the bug label Jun 2, 2023
@abernix
Copy link
Member

abernix commented Aug 21, 2023

This could be a consideration of #3226!

@abernix abernix mentioned this issue Aug 21, 2023
Open
28 tasks
@abernix abernix added component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it. component/logging story/logging labels Aug 21, 2023
@bnjjj bnjjj mentioned this issue Jun 17, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnjjj bnjjj

Labels
bug component/logging component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it. story/logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(telemetry): always create trace id even if the trace is not sampled apollographql/router
2 participants
@abernix @bnjjj