-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error section in custom attributes configuration #1434
Comments
Q: Will the user be able to specify more than one error section? If not then Is there a possibility that users will want to filter only on certain paths of error. Not saying that this is a requirement, just posing the question. |
No only one error. It's already written |
So if there's only one |
Updated ! Thanks :) |
just checking: extensions is an array? If so the example yaml needs a dash. |
Ok after some investigations we don't fill the path and locations field when we have an error in the subgraph http request. So for now I will omit these fields and do not add the ability to include them. telemetry:
metrics:
prometheus:
enabled: true
common:
attributes:
subgraph:
all:
errors: # Only works if it's a valid GraphQL error
include_messages: true # Will include the error message in a message attribute
extensions: # Include extension data
- name: subgraph_error_extended_type # Name of the attribute
path: .type # JSON query path to fetch data from extensions |
What is missing in our implementation for custom attributes and could be useful is to add an
error
subsection to reflect the same behavior we have in our plugin hooks. For example instead of having:we could have :
Originally posted by @bnjjj in #1198 (comment)
The text was updated successfully, but these errors were encountered: