Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request_timeout to traffic shaping plugin #1275

Closed
BrynCooke opened this issue Jun 17, 2022 · 4 comments · Fixed by #1347
Closed

Add request_timeout to traffic shaping plugin #1275

BrynCooke opened this issue Jun 17, 2022 · 4 comments · Fixed by #1347
Assignees
@bnjjj

Comments

@BrynCooke
Copy link
Contributor

This needs to be configurable at the overall router_service and at the subgraph level.
Config could follow the shape recently discussed in #1162
@deweyjose
Copy link
Contributor

This would be extremely useful for our use-cases as well.

@bnjjj
Copy link
Contributor

bnjjj commented Jul 5, 2022

Hello @deweyjose ! It's currently in progress. Hopefully it will be available soon

@deweyjose
Copy link
Contributor

Hello @deweyjose ! It's currently in progress. Hopefully it will be available soon

Just to confirm - we'll have the ability to apply timeout configuration for all requests as well as customize timeouts per sub-graph?

@bnjjj
Copy link
Contributor

bnjjj commented Jul 8, 2022

Yes exactly ! You can take a look at this PR #1347

@bnjjj bnjjj mentioned this issue Jul 8, 2022
Merged
@bnjjj bnjjj self-assigned this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnjjj bnjjj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support of rate limit and timeout apollographql/router
3 participants
@BrynCooke @bnjjj @deweyjose