From 849c5d0a21189ed1d2e8eacab923dfe5ad51b86a Mon Sep 17 00:00:00 2001 From: bryn Date: Mon, 28 Aug 2023 20:32:09 +0100 Subject: [PATCH] Fix metrics attribute types Metrics attributes were being coerced to strings. This is now fixed. In addition, the logic around types accepted as metrics attributes has been simplified. It will log and ignore values of the wrong type. Fixes #3691 --- .changesets/fix_bryn_fix_metrics_typing.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changesets/fix_bryn_fix_metrics_typing.md diff --git a/.changesets/fix_bryn_fix_metrics_typing.md b/.changesets/fix_bryn_fix_metrics_typing.md new file mode 100644 index 00000000000..b4f26d67edf --- /dev/null +++ b/.changesets/fix_bryn_fix_metrics_typing.md @@ -0,0 +1,6 @@ +### Fix metrics attribute types ([Issue #3687](https://github.com/apollographql/router/issues/3687)) + +Metrics attributes were being coerced to strings. This is now fixed. +In addition, the logic around types accepted as metrics attributes has been simplified. It will log and ignore values of the wrong type. + +By [@BrynCooke](https://github.com/BrynCooke) in https://github.com/apollographql/router/pull/3701