Old data still hanging around after a new request has errored

[dallonf]

Intended outcome:

Refetching a query that caused an error with new variables should clear out the old data and provide all the data that was returned from the GraphQL result.

Example: https://codesandbox.io/s/n73jj3x70
(this is the same code example as #1817)

Actual outcome:

I get the error alongside the data from the previous query.

How to reproduce the issue:

Example: https://codesandbox.io/s/n73jj3x70
(this is the same code example as #1817)

1. Type a valid name: "Fred"
2. Type a new name that throws an error: "Bob"

Note that the old data ("Hello, Fred!") is still hanging around.

Note react-apollo is at 2.1.0-rc.5; on the latest version (2.0.4), you will instead observe #1336, and the state will switch to loading: true but never actually make a request.

Version

• [email protected]
• [email protected]

[rosskevin]

Errored requests do not modify the cache. If you would like to see that change please file an issue with apollo-client.