Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undefined path in getErrorsFromParent #667

Merged
merged 4 commits into from
Mar 13, 2018

Conversation

amkoehler
Copy link
Contributor

@amkoehler amkoehler commented Mar 7, 2018

Added falsy check for the error.path value in getErrorsFromParent. If the path is undefined, the function will return the error with kind: OWN for the given field.

Added falsy check for the `error.path` value
in `getErrorsFromParent`. If the path is undefined, the function will
return the error with as OWN for the given field.
@apollo-cla
Copy link

@amkoehler: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@amkoehler
Copy link
Contributor Author

amkoehler commented Mar 7, 2018

This is related to #617. That PR only covered annotateWithChildrenErrors . I added a similar check within getErrorsFromParent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants