Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow GraphiQLOptions to be a function #426

Merged
merged 7 commits into from
Jun 20, 2017
Merged

Allow GraphiQLOptions to be a function #426

merged 7 commits into from
Jun 20, 2017

Conversation

NeoPhi
Copy link
Contributor

@NeoPhi NeoPhi commented Jun 13, 2017 •
edited
Loading

This is a proposed implementation to address #418.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@helfer
Copy link
Contributor

helfer commented Jun 14, 2017

@NeoPhi Thanks, looks good but one of the tests that you added currently fails on Node 8. Can you look into that?

helfer
helfer approved these changes Jun 14, 2017
View reviewed changes
Copy link
Contributor

@helfer helfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks a lot @NeoPhi! 🙂
What do you think about adding some tests specifically for the new resolveGraphiQLString file?

@helfer
Copy link
Contributor

helfer commented Jun 16, 2017

Also @NeoPhi would you mind rebasing on the new master so we can merge it? 🙏

@NeoPhi
Copy link
Contributor Author

NeoPhi commented Jun 16, 2017

@helfer I think this is ready now.

@helfer
Copy link
Contributor

helfer commented Jun 20, 2017

Ok, lgtm @NeoPhi!

@helfer helfer merged commit 54d7d9e into apollographql:master Jun 20, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@helfer helfer helfer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeoPhi @helfer