-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to fix Koa integration tests on Node v4 #329
Comments
from koa's offical github: |
We could use babel with babel-register to compile the code on the fly before execution. Koa mentions this in the README: |
as much as i know apollo doesn't want to use babel, |
This is indeed a little bit annoying. I think the best path forward is as @DxCx suggested: disable Koa tests on node 4 and support only Koa 2 going forward. |
Yeah im sorry that was node 6.. |
@helfer do we want to remove support from KOA on both Node 4 and 6 or split packages for KOA1 and KOA2? |
@DxCx I'd be happy to remove Koa support for Node 4 and 6 going forward. I don't think it makes sense for us to put in the work if neither of us are using it. If someone who is using Koa comes forward and wants to maintain that part and make separate versions for Koa 1 and 2, we can still do that. |
KoA integration tests are broken on node 4. seems like koa uses es6 features.
we need to dig deeper to understand what was changed exactly, and make sure that the latest supported koa for node 4 i supported by us as well.
Temporary W/A which just disables Koa tests on node v4: #328
The text was updated successfully, but these errors were encountered: