Skip to content

Commit

Permalink
Only widen the semver range for the graphql dependency of `apollo…
Browse files Browse the repository at this point in the history
…`. (#1103)

Per the correct assessment of what we want from the `graphql` package within
the `apollo` package, in the following conversation:

#1078 (comment)

Specifically, we're okay using whatever 14.x version of `graphql` is
potentially already available to us when someone installs `apollo` into
their application's `devDependencies` in an existing application.

If the existing application doesn't already have a 14.x version of `graphql`
we will use the latest `14.x` version.

With any success, this will cl_ose #1078 automatically (and not just because
I said "close PR number" in this commit message!).
  • Loading branch information
abernix authored Mar 11, 2019
1 parent 8739946 commit 54a68f2
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@
"packageRules": [
{
"paths": ["packages/apollo/package.json"],
"extends": [":pinAllExceptPeerDependencies"]
"extends": [":pinAllExceptPeerDependencies"],
"packageRules": [
{
"packageNames": ["graphql"],
"rangeStrategy": "widen",
"allowedVersions": "^14.0.0"
}
]
},
{
"packageNames": ["@oclif/config"],
Expand Down

0 comments on commit 54a68f2

Please sign in to comment.