Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS3 apollo-server-lambda: drop callback support #5147

Closed
glasser opened this issue Apr 30, 2021 · 1 comment
Closed

AS3 apollo-server-lambda: drop callback support #5147

glasser opened this issue Apr 30, 2021 · 1 comment

Comments

@glasser
Copy link
Member

glasser commented Apr 30, 2021

As of recently, the handler in apollo-server-lambda can be called either with a callback or as an async function. We believe that all currently running Lambda Node runtimes support the async version. Now, some folks may be wrapping our handler with their own handler and calling it callback-style, but AS3 is a fine time to drop the complexity (including weirder types, see #5072) and only export an async handler.

@glasser glasser added this to the Release 3.x milestone Apr 30, 2021
@glasser
Copy link
Member Author

glasser commented May 2, 2021

Duplicate of #5018

@glasser glasser marked this as a duplicate of #5018 May 2, 2021
@glasser glasser closed this as completed May 2, 2021
@glasser glasser removed this from the Release 3.x milestone Jun 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant