Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a major release of apollo-server-cache-redis changing the interface #5099

Closed
glasser opened this issue Apr 9, 2021 · 2 comments
Closed

Comments

@glasser
Copy link
Member

glasser commented Apr 9, 2021

The AS 2.23 release includes a v1.4.0 release of apollo-server-cache-redis which introduces BaseRedisCache into which you inject a redis client, and changes RedisCache and RedisClusterCache into being wrappers around these that construct the client for you. This way we don't have to worry about "but do we support every potential redis client constructor shape" like we did with the old classes.

We should consider (either as part of the AS3 lifecycle, or just independently) releasing a major version bump of this package which renames BaseRedisCache back to RedisCache and drops the old wrappers.

@glasser glasser added this to the Release 3.x milestone Apr 9, 2021
@glasser
Copy link
Member Author

glasser commented May 2, 2021

I'm going to remove this from the AS3 milestone. While it may be a good idea, the versioning schema of ASCR is not related to AS' own versioning, so we can put out a v2 of it at any time.

@glasser glasser removed this from the Release 3.x milestone May 2, 2021
@trevor-scheer
Copy link
Member

Closing as no longer relevant, since we no longer maintain these cache wrappers ourselves and instead defer to the keyv project for this kind of functionality.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants