Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set channel name in subscription resolver dynamically #1474

Closed
serle opened this issue Aug 2, 2018 · 1 comment
Closed

Can't set channel name in subscription resolver dynamically #1474

serle opened this issue Aug 2, 2018 · 1 comment
Labels
⛲️ feature New addition or enhancement to existing solutions

Comments

@serle
Copy link

serle commented Aug 2, 2018

The current subscription resolver design assumes that the channel name in the subscription resolver is hard coded as the subscription resolver lambda function takes no parameters thus it is not possible to bring information such as the subscription variables and connection context into the scope of the resolver.

I need the ability to have access to the subscription parameters in the subscription resolver lambda function to be able to dynamically determine the channel based on the subscription variables. All examples of subscritions assume a hard-coded channel name which limits one to have a design which assumes a one-to-one mapping between subscription name and channel name. In our case we have one subscription and need to route the user to the correct channel based on the subscription variables.

Without such capability our team will be forced to use another non-GraphQL pupsub implementation even though all the other communication in our application happens over GraphQL. I have logged this issue on various forums including previously on issue #1385, but it seems to attract no attention.

/label critical feature

@ghost ghost added the critical feature label Aug 2, 2018
@abernix abernix added ⛲️ feature New addition or enhancement to existing solutions and removed critical feature labels Sep 26, 2018
@jbaxleyiii jbaxleyiii added the 🚧👷‍♀️👷‍♂️🚧 in triage Issue currently being triaged label Jul 8, 2019
@jbaxleyiii
Copy link
Contributor

@serle we are planning on doing another large revision of subscriptions in the Apollo Server 3.0 (#2360) and have added this to our project to track it there!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⛲️ feature New addition or enhancement to existing solutions
Projects
None yet
Development

No branches or pull requests

3 participants