Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parsing support for Type #715

Closed
lrlna opened this issue Oct 31, 2023 · 0 comments · Fixed by #718
Closed

add parsing support for Type #715

lrlna opened this issue Oct 31, 2023 · 0 comments · Fixed by #718
Assignees
Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation apollo-parser

Comments

@lrlna
Copy link
Member

lrlna commented Oct 31, 2023

Similar to #681, @field directive can be provided with Type information in a string form, which will then need to be parsed before being used in the schema. It seems like it does not need to be validated specifically (but we should do it anyways)

To make this change, we need to:

  1. add parse_type method to apollo-parser
  2. add a cst::Type specific method for SyntaxTree implementation to return the CST node, similar to doc.document(), and field_set.field_set()
  3. create a parse_type method in apollo-compiler
  4. add Type struct to apollo-compiler's schema that would also be able to include BuildErrors
  5. add a parse and validate methods to the Type struct impl
@lrlna lrlna added the apollo-compiler issues/PRs pertaining to semantic analysis & validation label Oct 31, 2023
@lrlna lrlna self-assigned this Oct 31, 2023
This was referenced Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation apollo-parser
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant