Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infinite loop when giving a bad input string value #266

Closed
bnjjj opened this issue Aug 2, 2022 · 1 comment · Fixed by #267
Closed

infinite loop when giving a bad input string value #266

bnjjj opened this issue Aug 2, 2022 · 1 comment · Fixed by #267
Assignees
@bnjjj
Labels
triage

Comments

@bnjjj
Copy link
Contributor

bnjjj commented Aug 2, 2022 •
edited
Loading

Description

When the subgraph schema is malformed or contains a typo rover crash with a timeout without any understandable errors.

Steps to reproduce

use this schema:

extend schema
  @link(url: "https://specs.apollo.dev/federation/v2.0",
        import: ["@key", "@external])

Look at the unclosed "@external
@bnjjj
Copy link
Contributor Author

bnjjj commented Aug 2, 2022

It's an apollo-rs bug. I will transfer the issue.

@bnjjj bnjjj transferred this issue from apollographql/rover Aug 2, 2022
@bnjjj bnjjj changed the title rover timeout without any understandable error for a bad graphql schema file infinite loop when giving a bad input string value Aug 2, 2022
@bnjjj bnjjj self-assigned this Aug 2, 2022
@bnjjj bnjjj mentioned this issue Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnjjj bnjjj

Labels
triage
Projects
None yet
Milestone
No milestone
1 participant
@bnjjj