Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with toString as a cache key for GraphQL input types #997

Merged
merged 2 commits into from
Aug 3, 2018
Merged

Fix issue with toString as a cache key for GraphQL input types #997

merged 2 commits into from
Aug 3, 2018

Commits on Jul 18, 2018

  1. Fix issue with toString as a cache key for GraphQL input types 

    For GraphQL input types if they are involved in building cache key we were using plain `.toString` call.
With this commit we first serialize input type to map, resolve all variable references and sort by name, then serialize result map to json string.

Closes apollographql#977
Closes apollographql#941
    @sav007
    sav007 committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    cfc6048 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2018

  1. Address feedback

    @sav007
    sav007 committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    686afcc View commit details
    Browse the repository at this point in the history