Fix issue with toString as a cache key for GraphQL input types #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For GraphQL input types if they are involved in building cache key we were using plain `.toString` call. With this commit we first serialize input type to map, resolve all variable references and sort by name, then serialize result map to json string. Closes apollographql#977 Closes apollographql#941
digitalbuddha
previously requested changes
Jul 30, 2018
digitalbuddha
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For GraphQL input types if they are involved in building cache key we were using plain
.toStringcall.With this commit we first serialize input type to map, resolve all variable references and sort by name, then serialize result map to json string.
Closes #977
Closes #941