Deffer accessing to apollo extension properties until task execution #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sav007
force-pushed
the
bug/gradle-lazy-property-evaluation
branch
from
2c62663
to
4c420a3
Compare
The issue has been discovered with plain java projects that seems gradle evaluate differently than android projects. All plugin configuration extension properties were ignored because they were accessing too soon. This PR wraps plugin extension properties with `Property` class to provide lazy evaluation for tasks during their execution. By using `Property` wrapper the min required version of gradle is bumped to 4.+. Some classes were converted back to groovy, that is done intentionally as there is some `black magic` is going on by gradle generating additional code for properties.
sav007
force-pushed
the
bug/gradle-lazy-property-evaluation
branch
from
4c420a3
to
a643126
Compare
digitalbuddha
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue has been discovered with plain java projects that seems gradle evaluate differently than android projects. All plugin configuration extension properties were ignored because they were accessing too soon. This PR wraps plugin extension properties with
Propertyclass to provide lazy evaluation for tasks during their execution. By usingPropertywrapper the min required version of gradle is bumped to 4.3+. Some classes were converted back to groovy, that is done intentionally as there is someblack magicis going on by gradle generating additional code for properties.This PR fixes another issue generated files for removed graphql queries are not deleted.