Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear stale files, trigger re-generation on plugin configuration change #810

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Clear stale files, trigger re-generation on plugin configuration change #810

merged 1 commit into from
Jan 29, 2018

Conversation

sav007
Copy link
Contributor

@sav007 sav007 commented Jan 28, 2018

Closes #424

@sav007 sav007 requested a review from marwanad January 28, 2018 20:51
digitalbuddha
digitalbuddha approved these changes Jan 28, 2018
View reviewed changes
Copy link
Contributor

@digitalbuddha digitalbuddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project.tasks.findByName(

  •    "compile${taskName.capitalize()}Kotlin") seems prime for flakiness will fix if I find better.

@sav007 sav007 force-pushed the feature-424/clear-stale-files branch from 5640610 to 0bc3cd8 Compare January 29, 2018 14:17
@sav007 sav007 force-pushed the feature-424/clear-stale-files branch from 0bc3cd8 to 3c11f0e Compare January 29, 2018 14:55
@sav007 sav007 merged commit b41c1f1 into apollographql:master Jan 29, 2018
@sav007 sav007 deleted the feature-424/clear-stale-files branch January 29, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalbuddha digitalbuddha digitalbuddha approved these changes

@marwanad marwanad Awaiting requested review from marwanad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sav007 @digitalbuddha