Introduce InputType for optional values with undefined state #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce wrapper class InputType for optional values that can be in 3 states: some value, null and undefined. Update generation of input object types to utilize new InputType wrapper and don't serialize optional value if it's undefined. Closes apollographql#652
sav007
force-pushed
the
feature-652/input-type
branch
from
337ac2b
to
8482d6c
Compare
BenSchwab
approved these changes
Sep 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce wrapper class InputType for optional values that can be in 3 states: some value, null and undefined.
Update generation of input object types to utilize new InputType wrapper and don't serialize optional value if it's undefined.
Example of new version of generated input type: https://github.com/apollographql/apollo-android/pull/658/files#diff-3e61595a5be610256c7f274f6f95d5f5
Closes #652