Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codegen] Use layout in data builder names #6195

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[codegen] Use layout in data builder names #6195

merged 1 commit into from
Oct 10, 2024

Conversation

martinbonnin
Copy link
Contributor

layout properly escapes type names in case of name clash.

See #5537

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 10, 2024 •
edited
Loading

✅ Docs Preview Ready

No new or changed pages found.

@netlify Netlify
Copy link

netlify bot commented Oct 10, 2024 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 4a2a50d
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/67079b4e8118ba0008921c4d

@martinbonnin martinbonnin mentioned this pull request Oct 10, 2024
Open
BoD
BoD approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 4f964f3 into main Oct 10, 2024
10 checks passed
@martinbonnin martinbonnin deleted the escape-data-builders branch October 10, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinbonnin @svc-apollo-docs @BoD