Introduce record version history for optimistic store #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sav007
force-pushed
the
feature-583/optimistic-store-record-journal
branch
3 times, most recently
from
5e600d6
to
d34addb
Compare
Rolling back optimistic updates is smart now, it keeps the history of record updates. If mutation finished it's execution it rolls back only its version of the record and keeps the rest versions for still running mutations. Closes apollographql#583
sav007
force-pushed
the
feature-583/optimistic-store-record-journal
branch
from
d34addb
to
f22f3f1
Compare
BenSchwab
approved these changes
Aug 10, 2017
| return changedCacheKeys; | ||
| } | ||
|
|
||
| private final class RecordJournal { |
digitalbuddha
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolling back optimistic updates is smart now, it keeps the history of record updates.
If mutation finished it's execution it rolls back only its version of the record and keeps the rest versions for still running mutations.
Closes #583