Remove existing interceptors from ApolloClient.Builder before adding new ones #5858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…autoPersistedQueries()
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
commented
Apr 29, 2024
...lo-http-cache/src/main/kotlin/com/apollographql/apollo3/cache/http/CachingHttpInterceptor.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This goes one step in the good direction but I think this API is still problematic. The fact that for an example, ApolloClient.Builder.autoPersistedQueries() is adding an interceptor under the hood is problematic. Code like this is a code smell.
|
I'm thinking the order should always be:
? HTTP cache itself is a bit awkward because it spans 2 different domains (GraphQL + HTTP). From a quick cursory glance, it looks like it can be anywhere and is probably not going to disturb other |
That sounds right to me 👍 |
martinbonnin
approved these changes
May 2, 2024
Logged #5874 about this. |
BoD
added a commit
to BoD/apollo-kotlin
that referenced
this pull request
Jul 1, 2024
…new ones (apollographql#5858) * Remove existing ApolloInterceptors when calling ApolloClient.Builder.httpCache() * Remove existing ApolloInterceptors when calling ApolloClient.Builder.autoPersistedQueries() * Remove existing HttpInterceptors when calling ApolloClient.Builder.httpCache() * Remove existing HttpInterceptors when calling ApolloClient.Builder.httpBatching() * Add a test for httpCache * Don't crash if no `X-APOLLO-SERVED-DATE` header is present * Revert CachingHttpInterceptor change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #5857, for
.httpCache(),.autoPersistedQueries()and.httpBatching().