Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sendApqExtensions and sendDocument from MutableExecutionOptions #5723

Closed
martinbonnin opened this issue Mar 13, 2024 · 2 comments · Fixed by #5733
Closed

Remove sendApqExtensions and sendDocument from MutableExecutionOptions #5723

martinbonnin opened this issue Mar 13, 2024 · 2 comments · Fixed by #5733

Comments

@martinbonnin
Copy link
Contributor

martinbonnin commented Mar 13, 2024 •
edited
Loading

I don't think it makes sense to have a default at the ApolloClient layer?

Can probably remove addInterceptors too.
@martinbonnin martinbonnin mentioned this issue Mar 15, 2024
Merged
@martinbonnin
Copy link
Contributor Author

I ended up keeping them around because they may be useful for persisted queries scenarios

@github-actions GitHub Actions
Copy link
Contributor

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Kotlin usage and allow us to serve you better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More KDoc and deprecate ApolloClient.Builder.addInterceptors() apollographql/apollo-kotlin
1 participant
@martinbonnin