Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read operation/fragment from store #480

Merged

Conversation

sav007
Copy link
Contributor

@sav007 sav007 commented May 3, 2017

Add read function to read operations from ApolloStore.
Prepare class generation for reading fragments from store.
Add function to read fragment from store.

Part of #467

Add read function to read operations from ApolloStore.
Prepare class generation for reading fragments from store.
sav007 added 3 commits May 3, 2017 17:17
Add function to read fragment from ApolloStore.
Add simple unit test
@sav007 sav007 changed the title Read operation from store Read operation/fragment from store May 3, 2017
/**
* Represents a GraphQL fragment
*/
public interface Fragment {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe name this GraphqlFragment so that autoimport in android will be happier

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

/**
* Represents a GraphQL fragment
*/
public interface Fragment {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

sav007 added 5 commits May 5, 2017 13:49
# Conflicts:
#	apollo-integration/src/test/java/com/apollographql/apollo/NormalizedCacheTestCase.java
#	apollo-runtime/src/main/java/com/apollographql/apollo/internal/cache/normalized/NoOpApolloStore.java
#	apollo-runtime/src/main/java/com/apollographql/apollo/internal/cache/normalized/RealApolloStore.java
#	apollo-runtime/src/main/java/com/apollographql/apollo/internal/cache/normalized/WriteableStore.java
#	apollo-runtime/src/main/java/com/apollographql/apollo/internal/field/CacheFieldValueResolver.java
#	apollo-runtime/src/main/java/com/apollographql/apollo/internal/interceptor/ApolloCacheInterceptor.java
@sav007 sav007 merged commit 22098be into apollographql:master May 5, 2017
@sav007 sav007 deleted the feature-467/read-operation-from-store branch May 5, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants