Data Builders for fragments and customScalarAdapters for map builders #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or fragments implementations
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
commented
Aug 12, 2022
| resolver: FakeResolver, | ||
| type: CompiledType | ||
| ): T { | ||
| val map = if (block == null) { |
There was a problem hiding this comment.
This has to be a relatively different code path because fragments can be on interfaces types so we can't know in advance the builder to instanciate:
FragmentImpl.Data {
// buildDroid is also an option
buildHuman {
...
}
}QueryImpl.Data {
// here the receiver is always QueryBuilder
name = ...
}
martinbonnin
commented
Aug 12, 2022
...compiler/src/main/kotlin/com/apollographql/apollo3/compiler/codegen/kotlin/KotlinResolver.kt
Show resolved
Hide resolved
martinbonnin
commented
Aug 12, 2022
| @@ -25,7 +26,7 @@ class IncludeTest { | |||
| fun includeVariableTrue() = runBlocking { | |||
| val operation = GetCatIncludeVariableQuery(withCat = true) | |||
|
|
|||
| val data = buildQuery { | |||
| val data = GlobalBuilder.buildQuery { | |||
There was a problem hiding this comment.
This is slightly less ergonomic but it's the price to pay to allow runtime adapters if needed:
Builder(customScalarAdapters).buildQuery {
...
}
BoD
reviewed
Aug 12, 2022
| HeroWithFriendsFragment( | ||
| id = "2001", | ||
| name = "R222-D222", | ||
| HeroWithFriendsFragmentImpl.Data { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.