Pagination: add connectionFields argument to @typePolicy #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
…, and add it to @typePolicy.connectionFields
BoD
commented
Jul 15, 2022
| } | ||
|
|
||
| private val GQLTypeDefinition.directives |
There was a problem hiding this comment.
This could be on GQLTypeDefinition directly instead of an extension?
There was a problem hiding this comment.
If we're going that road, we could add a GQLHasDirectives interface like there is GQLNamed and GQLDescribed. I'm not 100% sure the implications of this though.
…resOptIn, and add it to @typePolicy.connectionFields" This reverts commit f3a95a3.
…no import is specified). `connectionFields` is on v0.2 only and made opt-in that way
| */ | ||
| fun apolloDefinitions() = definitionsFromResources("apollo.graphqls") | ||
| fun apolloDefinitions() = apolloDefinitions("v0.1") |
There was a problem hiding this comment.
Probably make apolloDefinitions(version: String) public if we want to keep offering that possibility. I'd be surprised if anyone is relying on this at the moment but it might be useful for some use cases?
| # | ||
| # extend schema @link(url: "https://specs.apollo.dev/kotlin_labs/v0.1", import: ["@optional", "@nonnull", "@typePolicy", "@fieldPolicy"]) | ||
| # extend schema @link(url: "https://specs.apollo.dev/kotlin_labs/v0.1", import: ["@optional", "@nonnull", "@typePolicy", "@fieldPolicy", "requiresOptIn", "targetName"]) |
martinbonnin
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify the Relay/Connection style pagination, a new
connectionsFieldsargument is added to@typePolicy:This also generates a new
Paginationobject with aconnectionTypes: Set<String>field, which can be passed toConnectionMetadataGenerator(now available inapollo-normalized-cache-api-incubating, among withConnectionMetadataGenerator).The
connectionFieldsargument must be opted-in by linking (importing) thekotlin_labsv0.2 directives like so:See also this PR that adds kotlin_labs v0.2 to the public specs site.