Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧰 introduce apollo-tooling and apollo-cli #4153

Merged
merged 9 commits into from
Jun 2, 2022
Merged

🧰 introduce apollo-tooling and apollo-cli #4153

merged 9 commits into from
Jun 2, 2022

Conversation

martinbonnin
Copy link
Contributor

Shuffle a bit the dependencies:

  • the introspection API goes into apollo-ast because they work with the apollo-ast Schema. It's a bit of a stretch (this module should be apollo-language or something like this) but I think it's okay.
  • It is kept as a convenience in apollo-compiler even though it was technically experimental before so we can certainly remove this before 4.0
  • SchemaDownloader, SchemaUploader, RegisterOperations go into apollo-tooling
  • Both apollo-cli and apollo-gradle-plugin use apollo-tooling to expose functionality either through Gradle or through the cli
  • There's a apollo-kotlin.main.kts helper script that's an easy way to start the cli. It'd be interesting to ditribute it on sdkman, npm, or another package manager one of these days.

@netlify
Copy link

netlify bot commented Jun 1, 2022

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit d3ae4a1
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/629875c5a290fd0008ecf0a5

@file:Repository("https://repo.maven.apache.org/maven2/")
@file:Repository("file://Users/mbonnin/.m2/repository")

@file:DependsOn("com.apollographql.apollo3:apollo-cli:3.3.1-SNAPSHOT")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be updated when making a release right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not really sure where I'm going with this. It's just an easy way to call into the cli without having to manually download the jar and invoke java. I'm happy to remove it and we can look into packaging/distribution later.

apollo-cli/apollo-kotlin.main.kts Outdated Show resolved Hide resolved
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit c8227a7 into main Jun 2, 2022
@martinbonnin martinbonnin deleted the apollo-cli branch June 2, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants