Sort the type names in the list so the code gen is deterministic.

[eboudrant]

Fix for #4137

[netlify]

👷 Deploy request for apollo-android-docs pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	600772f

[martinbonnin]

Thanks for sending this! Out of curiosity, are you seeing discrepancies only in Schema.kt?
I was expecting mutableMapOf<>() to have stable iteration order so that the codegen would be stable too. If it's not the case we might have issues in other places too....

[eboudrant]

I only looked at Schema.kt for the moment, we could have more problems. I'd like to test it on my branch, what's the best way to build the plugin locally?

[martinbonnin]

There's some info in the CONTRIBUTING.md. TLDR; ./gradlew publishToMavenLocal

[martinbonnin]

The CI failed (expectedly) because the compiler tests output changed. You can update them with ./gradlew :apollo-compiler:test -DupadteTestFixtures=true

But it's still weird that we haven't seen any issue like this in the repo. Is there anything in your CI setup that could explain the instability? Java version, gradle parameters, anything else?

[eboudrant]

We're looking if there was a change in CI. Not at my knowledge but we've seen similar issue with Autovalue Gson code gen.

[eboudrant]

@martinbonnin should I also update the class com.apollographql.apollo3.compiler.codegen.java.file.SchemaBuilder?

[martinbonnin]

should I also update the class com.apollographql.apollo3.compiler.codegen.java.file.SchemaBuilder

That'd be nice, if the bug exists with Kotlin codegen there's a high chance it is in the Java codegen too. Also keeps the both codegen symmetrical so 👍

[eboudrant]

I'm not sure why this line was added?

[martinbonnin]

2 PRs were merged in parallel:

• https://github.com/apollographql/apollo-kotlin/pull/4133/files added a test but did not update measurements (not sure why)
• 🤝 update CONTRIBUTING.md #4132 changed the format of measurements

So in the end 4132 was merged without the new test that you just added. So thank you :)

FWIW, this file is informative only. It's used to keep track of the size of codegen. It's handy to have it commited because it allows to easily bisect if there is a regression but we might as well put it in .gitignore

[BoD]

👍