🧶 Use a getter instead of a const val OPERATION_QUERY #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because enormous (64kB) strings cannot fit into a single constant in JVM bytecode, but the Kotlin compiler will compile huge string literals as runtime concatenation of smaller constants. Using a getter instead of a val with a backing field so that for most users, this does not have any practical impact (as r8 should be able to inline the simple getter function into a string constant load).
|
@ephemient: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-android-docs pending review.Visit the deploys page to approve it
|
ephemient
changed the title
BoD
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because enormous (64kB) strings cannot fit into a single constant in JVM
bytecode, but the Kotlin compiler will compile huge string literals as
runtime concatenation of smaller constants.
Using a getter instead of a val with a backing field so that for most
users, this does not have any practical impact (as r8 should be able to
inline the simple getter function into a string constant load).