⚡ Ignore unknown websocket messages #4066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martinbonnin
commented
Apr 27, 2022
martinbonnin
commented
- ignore unknown websocket messages
- add a test
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
commented
Apr 27, 2022
...e-plugin/src/main/kotlin/com/apollographql/apollo3/gradle/internal/DefaultApolloExtension.kt
Show resolved
Hide resolved
martinbonnin
commented
Apr 27, 2022
| import com.apollographql.apollo3.network.ws.WebSocketEngine | ||
| import okio.ByteString | ||
|
|
||
| class FakeWebSocketEngine(val onReceive: suspend () -> String, val onSend: (String) -> Unit) : WebSocketEngine { |
There was a problem hiding this comment.
This could be promoted to apollo-testing-support at some point.
BoD
reviewed
Apr 27, 2022
| /** | ||
| * Parses a WebSocket message containing Json to a Map<String, Any?> | ||
| * | ||
| * @return the map representing the Json or [null] if the message is not a Json object |
There was a problem hiding this comment.
Kind of wondering why it happens
There was a problem hiding this comment.
I have no idea but looks like it's a good application of the Robustness principle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.