-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add insecure option to download schema #4021
Add insecure option to download schema #4021
Conversation
@kdk96: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-android-docs pending review.Visit the deploys page to approve it
|
...o-gradle-plugin/src/test/kotlin/com/apollographql/apollo3/gradle/test/DownloadSchemaTests.kt
Show resolved
Hide resolved
apollo-gradle-plugin/src/main/kotlin/com/apollographql/apollo3/gradle/internal/SchemaHelper.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question but looks very good to me. Thanks 💙 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@martinbonnin hi, are we waiting for the last approval to merge pr? |
I think we are all good to go. It's just me behind super late in my Github notifications 😅 . I just re-run the CI to make sure latest merge is ok and will merge once everything is ✅ |
Thanks for the contribution 💙 |
Closes #3863