Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insecure option to download schema #4021

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

kdk96
Copy link
Contributor

@kdk96 kdk96 commented Apr 12, 2022

Closes #3863

@apollo-cla
Copy link

@kdk96: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@netlify
Copy link

netlify bot commented Apr 12, 2022

👷 Deploy request for apollo-android-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 54e6f86

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question but looks very good to me. Thanks 💙 !

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kdk96
Copy link
Contributor Author

kdk96 commented Apr 13, 2022

@martinbonnin hi, are we waiting for the last approval to merge pr?

@martinbonnin
Copy link
Contributor

I think we are all good to go. It's just me behind super late in my Github notifications 😅 . I just re-run the CI to make sure latest merge is ok and will merge once everything is ✅

@martinbonnin martinbonnin merged commit 223ca3a into apollographql:main Apr 13, 2022
@martinbonnin
Copy link
Contributor

Thanks for the contribution 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ability to to trust self signed certificate for schema download task
4 participants