Add a Data.toJson that uses reflection to lookup the adapter #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
requested review from
BoD,
sav007 and
tasomaniac
as code owners
BoD
reviewed
Dec 15, 2021
| return adapter.obj() | ||
| } | ||
|
|
||
| fun Operation.Data.toJson(jsonWriter: JsonWriter, customScalarAdapters: CustomScalarAdapters = CustomScalarAdapters.Empty) { |
There was a problem hiding this comment.
Should we mark it @ApolloExperimental?
There was a problem hiding this comment.
I was wondering the same. I decided not to because it's 2.x functionality for which we don't have a multiplatform equivalent yet. So it's not really new and it's not really deprecated either.
Once we have a multiplatform mockserver API, we'll mark this one as deprecated?
BoD
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A helper function to get a Json from a
Datainstance. This is a band-aid until we get better and multiplatform mockserver APIs