Add fallback to Object in case if there is no custom scalar type mapping specified #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalbuddha
approved these changes
Feb 9, 2017
|
Thanks :) |
|
you can start tagging @brianPlummer for reviews as well fyi. |
brianPlummer
reviewed
Feb 9, 2017
| case 3: { | ||
| contentValues.fieldWithUnsupportedType = (Object) value; | ||
| break; | ||
| } |
There was a problem hiding this comment.
would be good to have a default label...nitpick
There was a problem hiding this comment.
sorry what do you mean?
There was a problem hiding this comment.
A default case to the switch
There was a problem hiding this comment.
agh, well this code is generated, so we guarantee that there won't be default case
brianPlummer
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #173
If user didn't specify custom type mapping, Object will be used as java type for fields with GraphQL custom scalar.
As for the parsing response values for such fields it will be decided by json reader, that supports by default only 3 types: Boolean, String, BigDecimal.