Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backward compatibility issues with new code gen #1500

Merged

Conversation

sav007
Copy link
Contributor

@sav007 sav007 commented Aug 15, 2019

  • Relax mandatory comma rule for: arguments, variables, array definitions
  • Add support for comments

Closes #1496

- Relax mandatory `comma` rule for: arguments, variables, array definitions
- Add support for comments

Closes apollographql#1496
@sav007 sav007 merged commit 9ae328e into apollographql:master Aug 15, 2019
@sav007 sav007 deleted the bug-1496/fix-backward-compatibility-issues branch August 15, 2019 17:36
Copy link
Contributor

@tasomaniac tasomaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various problems with new experimental code generator
2 participants