Update .shasum file check for unzipping binary
#806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses something brought up a couple times, including in #805: Right now we're checking the output of
shasum, which is the actual SHASUM plus the full, hard-coded path used to create it. That doesn't help much if this file is checked into version control, which it would be if a developer checks in all their CocoaPods.To address this, I've:
.shasumfile to only look at the prefix, ie the actual SHASUM and not the path, for anyone with an existing.shasumfile..shasumfile to not write out the path in the future.Edit: I also snuck in a change to make sure the local
nodebinary included with Apollo is preferred to any other node version installed, which also should make sure there are no issues if no version of node is globally installed on a developer's computer.