Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error + Use Sorted Keys Where Possible #628

Merged
merged 3 commits into from
Jul 12, 2019

Conversation

designatednerd
Copy link
Contributor

Based on #624 and some of the failures we saw when @dmandarino tried to add a test, this fixes #623.

In this PR:

/me shakes fist at sky for .sortedKeys only being on iOS 11 and above

@designatednerd
Copy link
Contributor Author

@dmandarino wanna give me a ✅if you feel this is good or feedback if you have it?

@dmandarino
Copy link

@designatednerd Looks good to me. I've tested here too using the project I'm working on and everything looks fine and passed :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET is not working in 0.11.0
2 participants