-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make -[ApolloStore clearCache]
public
#518
make -[ApolloStore clearCache]
public
#518
Conversation
make clearCache() public
So I'm definitely in agreement with making How about adding a note to the documentation that if you're using the same cache across multiple, you should call the method on the store instead? |
It's bit confusing if we leave it... apolloClient.clearCache()
// do I need to call apolloClient.store.clearCache() as well? |
@RolandasRazma I think if you're only using one client and one cache (which is a fairly good chunk of our users), leaving it as a convenience would probably be better. Having it exposed separately is helpful for the people who need it, but I think for people who only need the one client and the one cache, it's easier to leave the existing behavior and expose the underlying |
This reverts commit d9d2c30.
IMO it brings unnecessary confusion, but it's your call. Removed deprecation. |
-[ApolloStore clearCache]
public and deprecate -[ApolloClient clearCache]-[ApolloStore clearCache]
public
I'll update some of the docs once this is merged to try to make it clearer when to use which one - thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go whenever Travis is
followup to #517
make
-[ApolloStore clearCache]
public.At the moment there is no way to clear cache unless you have access to
ApolloClient
. HavingclearCache()
onApolloClient
is not exactly correct as multipleApolloClient
can share same cache.