Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check type name conflicts in SelectionSet #3009

Merged
merged 6 commits into from
May 15, 2023
Merged

Check type name conflicts in SelectionSet #3009

merged 6 commits into from
May 15, 2023

Commits on May 12, 2023

  1. Check type name conflicts in SelectionSet 

    Adding validation to check for type name conflicts in selection set fields based on pluralization.
    @BobaFetters
    BobaFetters committed May 12, 2023
    Configuration menu
    Copy the full SHA
    cf742f4 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Adding additional test to cover fragment use case for merged fields 

    - Moved extension methods from `SelectionSetTemplate` to new `IR+Formatting.swift` file
- Updated algorithm to loop through and check nested fragments for merged field conflicts
- Added field to `typeNameConflict` error to be able to display the operation/fragment that contains the error
- Minor code cleanup
    @BobaFetters
    BobaFetters committed May 15, 2023
    Configuration menu
    Copy the full SHA
    1e65578 View commit details
    Browse the repository at this point in the history

  2. Updating tests and adding troubleshooting page 

    - Added a few more tests
- Added a troubleshooting page to further explain this issue.
    @BobaFetters
    BobaFetters committed May 15, 2023
    Configuration menu
    Copy the full SHA
    7040e0b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/conflicting-type-field-names

    @BobaFetters
    BobaFetters committed May 15, 2023
    Configuration menu
    Copy the full SHA
    deb8208 View commit details
    Browse the repository at this point in the history

  4. Fix SubscriptionAPI schema configuration

    @calvincestari
    calvincestari committed May 15, 2023
    Configuration menu
    Copy the full SHA
    03da4d2 View commit details
    Browse the repository at this point in the history

  5. Remove file author attribution

    @calvincestari
    calvincestari committed May 15, 2023
    Configuration menu
    Copy the full SHA
    a1e19b3 View commit details
    Browse the repository at this point in the history