fix: Disallow certain targetNames in code generation (#2958) #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new code gen error for `targetNameConflict` - Added new `SwiftKeywords` static set for `DisallowedEmbeddedTargetNames` - Updated `validate` function in `ApolloCodegen` to check for disallowed target names
|
@BobaFetters: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
✅ Deploy Preview for apollo-ios-docs canceled.
|
calvincestari
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
This looks good, thanks for the quick fix!
I questioned whether we should have another test in CodegenCLITests::InitializeTests to validate the error is thrown to the command line during initialization but that validation is in another module with it's own test so I'm fine with it not being in the CLI tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new validation check to ensure the
targetNamegiven when using theembeddedInTargetmodule type does not conflict with existing libraries.