Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 1.1.2 #2947

Merged
merged 5 commits into from
Apr 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* _List the highlight PRs_

#### Things to do in this PR
- [ ] Update the version in [`Configuration/Shared/Project-Version.xcconfig`](https://github.com/apollographql/apollo-ios/blob/main/Configuration/Shared/Project-Version.xcconfig) and [Sources/CodegenCLI/Constants.swift](https://github.com/apollographql/apollo-ios/blob/main/Sources/CodegenCLI/Constants.swift#L4).
- [ ] Update the version constants using the `set-version.sh` script.
- [ ] Update [`CHANGELOG.md`](https://github.com/apollographql/apollo-ios/blob/main/CHANGELOG.md) with all relevant changes since the prior version. _Please include PR numbers and mention contributors for external PR submissions._
- [ ] Run the Documentation Generator as noted in [`api-reference.md`](https://github.com/apollographql/apollo-ios/blob/main/docs/source/api-reference.md) to re-generate documentation from source for all included libraries. _Make sure you are on HEAD of the parent branch otherwise the documentation generator will not catch all changes, rebase this PR if needed._

Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Change Log

## v1.1.2

### Fixed
- **Crash after calling `cancel()` on `Cancellable` ([#2932](https://github.com/apollographql/apollo-ios/issues/2932)):** Calling `cancel()` on a non-subscription `Cancellable` will now correctly handle the lifetime of the internally `Unmanaged` object. [#2943](https://github.com/apollographql/apollo-ios/pull/2943) - _Thank you to [@yonaskolb](https://github.com/yonaskolb) for raising the issue._
- **Deprecation messages are not escaped ([#2879](https://github.com/apollographql/apollo-ios/issues/2879)):** If escaped characters are used in GraphQL deprecation messages they are now properly escaped in the rendered Swift warning or attribution message. [#2951](https://github.com/apollographql/apollo-ios/pull/2951) _Thank you to [@djavan-bertrand](https://github.com/djavan-bertrand) for raising the issue._

### Added
- **Add injecting additionalErrorHandler for upload operations to RequestChainNetworkTransport ([#2948](https://github.com/apollographql/apollo-ios/pull/2948)):** `Upload` operations can now have custom error interceptors like other operations. [#2948](https://github.com/apollographql/apollo-ios/pull/2948) _Thank you to [@RobertDresler](https://github.com/RobertDresler) for the contribution._

## v1.1.1

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion Configuration/Shared/Project-Version.xcconfig
Original file line number Diff line number Diff line change
@@ -1 +1 @@
CURRENT_PROJECT_VERSION = 1.1.1
CURRENT_PROJECT_VERSION = 1.1.2
2 changes: 1 addition & 1 deletion Sources/CodegenCLI/Constants.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Foundation

public enum Constants {
public static let CLIVersion: String = "1.1.1"
public static let CLIVersion: String = "1.1.2"
static let defaultFilePath: String = "./apollo-codegen-config.json"
}
16 changes: 14 additions & 2 deletions scripts/set-version.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
#!/bin/bash

CURRENT_VERSION=$($(dirname "$0")/get-version.sh)

# Set configuration file version constant

source "$(dirname "$0")/version-constants.sh"

NEW_VERSION="$1"
Expand All @@ -11,5 +15,13 @@ NEW_VERSION="$1"

echo "$VERSION_CONFIG_VAR = $NEW_VERSION" > $VERSION_CONFIG_FILE

git add -A && git commit -m "$NEW_VERSION"
git tag "$NEW_VERSION"
# Set CLI version constant

MATCH_TEXT='CLIVersion: String = "'
SEARCH_TEXT="$MATCH_TEXT$CURRENT_VERSION"
REPLACE_TEXT="$MATCH_TEXT$NEW_VERSION"
sed -i '' -e "s/$SEARCH_TEXT/$REPLACE_TEXT/" $CLI_CONSTANTS_FILE

# Feedback
echo "Committing change from version $CURRENT_VERSION to $NEW_VERSION"
git add -A && git commit -m "Updated version numbers"
1 change: 1 addition & 0 deletions scripts/version-constants.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
VERSION_CONFIG_VAR="CURRENT_PROJECT_VERSION"
VERSION_CONFIG_FILE="Configuration/Shared/Project-Version.xcconfig"
CLI_CONSTANTS_FILE="Sources/CodegenCLI/Constants.swift"