Fix selection set value serialization when writing to cache #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… creating RecordSet
✅ Deploy Preview for apollo-ios-docs canceled.
|
AnthonyMDev
commented
Jan 13, 2023
| struct ResultNormalizerFactory { | ||
| private init() {} | ||
|
|
||
| static func selectionSetDataNormalizer() -> SelectionSetDataResultNormalizer { |
There was a problem hiding this comment.
I decided to create separate functions rather than normalizer(for: DataSource) because this way, each function returns the concrete type (instead of BaseGraphQLResultNormalizer). This allows the generic functions in the GraphQLExecutor to still specialize the function calls, using static dispatch instead of dynamic dispatch.
calvincestari
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2775
When writing a SelectionSets data back into the cache, custom scalars need to re-encoded into their
_jsonValue. Since we don't want to have to do this when writing network response data (which is already properly serialized JSON) we created a new normalizer and a factory to return the proper normalizer based on the data source.