Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download schema relative to root url #2609

Conversation

Anteo95
Copy link
Contributor

@Anteo95 Anteo95 commented Oct 26, 2022

This PR fixes downloading schema when "rootURL" is provided.

Currently, even though rootURL can be provided as parameter to function

  public static func fetch(
    configuration: ApolloSchemaDownloadConfiguration,
    withRootURL rootURL: URL? = nil
  )

it is actually not used internally on all places where it should be. This causes schema to be downloaded into incorrect folder.

@apollo-cla
Copy link

@Anteo95: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@netlify
Copy link

netlify bot commented Oct 26, 2022

👷 Deploy request for apollo-ios-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 277d577

@calvincestari calvincestari linked an issue Nov 1, 2022 that may be closed by this pull request
@calvincestari
Copy link
Member

Codegen CLI Integration Tests are failing because of a CocoaPods error with forks - merging anyways..

@calvincestari calvincestari merged commit 228aa52 into apollographql:main Nov 1, 2022
@calvincestari calvincestari mentioned this pull request Nov 1, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download schema relative to root url
3 participants