Fix Test Mock Custom Scalar conversion #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs canceled.
|
calvincestari
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON Encoding the Mocks into the
SelectionSet.DataDictwas causingCustomScalarvalues to get encoded into their JSON values.This implements a custom conversion of the Mock data into the correct format for the
SelectionSet.DataDict.Because of this, test mocks should have a dictionary of
[String: AnyHashable]instead ofJSONEncodableDictionary. We are not actually encoding these into JSON to convert to theSelectionSet.DataDictanymore.To make that work with
AnyHashableand the fields for lists of interfaces, we needed a coercive conversion function that forces the conversion ofArray<any AnyMock>toArray<AnyHashable>.Fixes #2582