Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping input params #2561

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Fix escaping input params #2561

merged 3 commits into from
Oct 11, 2022

Conversation

AnthonyMDev
Copy link
Contributor

@puls Thanks for the initial fix. This just adds tests and escapes the reserved names in the getters and setters as well.

puls and others added 2 commits October 7, 2022 19:42
I'm not sure if this is sufficient, but I have some input objects with fields named `in` and this change allows my generated code to compile.
@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for apollo-ios-docs canceled.

Name Link
🔨 Latest commit 665ae7e
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/6345ac95922bf4000a71c2c6

Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question. Thanks for the contribution @puls and the additional tests @AnthonyMDev

@AnthonyMDev AnthonyMDev merged commit 04c0eed into main Oct 11, 2022
@AnthonyMDev AnthonyMDev deleted the patch-1 branch October 11, 2022 17:49
@calvincestari calvincestari mentioned this pull request Oct 12, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants