Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace spectrum with Discourse #1857

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Replace spectrum with Discourse #1857

merged 2 commits into from
Jun 30, 2021

Conversation

martinbonnin
Copy link
Contributor

No description provided.

@calvincestari calvincestari self-requested a review June 30, 2021 16:24
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinbonnin!

@calvincestari
Copy link
Member

Worth noting that this takes them straight into contributing, i.e.: creating a new topic. I think that's OK vs. the alternative of searching for client and mobile tags.

@calvincestari calvincestari merged commit d0b9cf1 into main Jun 30, 2021
@calvincestari calvincestari deleted the martinbonnin-patch-1 branch June 30, 2021 16:36
@martinbonnin
Copy link
Contributor Author

Indeed, I added the query parameters after the fact. It might be worth changing the wording a bit so that it doesn't come as a surprise. Maybe "open a new topic in our community forums" instead of "join our community".

I'll leave it up to you.

@designatednerd
Copy link
Contributor

@calvincestari @martinbonnin There was a branch ages ago I started with more stuff on this that should still be floating around if y'all want to update and merge it

@AnthonyMDev AnthonyMDev added the no-changelog Indicates that changes from this PR do not need to be included in the changelog for their release. label Jul 6, 2021
ketenshi added a commit to scorebet/apollo-ios that referenced this pull request Aug 16, 2021
* main: (856 commits)
  Add execution tests for ApolloClient clearCache callback queue (apollographql#1901)
  Use the provided callback queue instead of the store's default. (apollographql#1904)
  chore(deps): update dependency path-parse to 1.0.7 [security] (apollographql#1899)
  Release - 0.46.0 (apollographql#1897)
  Update subscriptions tutorial to be compatible with recent changes (apollographql#1893)
  Add docs and improve merging of records from WebSockets into cache. (apollographql#1892)
  Publish response from the `WebSocketTransport` to the `ApolloStore` (apollographql#1889)
  fix(deps): update dependency gatsby-theme-apollo-docs to v4.7.14
  Removing Swift codegen (v1) (apollographql#1873)
  Update toolchain versions used by circleci (apollographql#1875)
  fix(deps): update dependency gatsby-theme-apollo-docs to v4.7.13
  Community Updates - ROADMAP/README (apollographql#1867)
  [Release] - 0.45.0 (apollographql#1862)
  WebSocket Fixes - Revert to Starscream 3.x and invert dependency (apollographql#1861)
  Docs/discussions_2_community branch changes (apollographql#1858)
  Replace spectrum with Discourse (apollographql#1857)
  fix(deps): update dependency gatsby-theme-apollo-docs to v4.7.12
  Configure Renovate (apollographql#1854)
  Revert "Reconfiguring renovate 2/2"
  Reconfiguring renovate 2/2
  ...

# Conflicts:
#	Sources/Apollo/GraphQLQueryWatcher.swift
#	Sources/ApolloWebSocket/WebSocketTransport.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that changes from this PR do not need to be included in the changelog for their release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants